$msid vs $sid, loop in list-cache.php

[mortonda@…]

list-cache.php illustrates a bigger problem throughout the codebase, where $sid and $msid are used to inject a php session id when needed into links. This convention predates my involvement in Maia, but I think the m stands for multiple, meaning it is used whenever there are more parameters to pass on, which is the error in list-cache.php.

Of interest, though, is the fact that $msid is also correct in single use situations - a trailing '&' doesn't affect anything. So should we just change authcheck.php to make $msid and $sid be equal, being '?PHPSESSID=' . session_id() . '&'

[mortonda@…]

[1305] and [1306] have this one part fixed. Still open is the question of whether $sid is even needed.