Opened 11 years ago

Last modified 11 years ago

#505 testing defect (fixed)

$msid vs $sid, loop in list-cache.php

Reported by: mortonda@… Owned by: mortonda@…
Priority: normal Milestone: 1.0.3
Component: PHP scripts Version: 1.0.2
Severity: normal Keywords:
Cc:

Description (last modified by mortonda@…)

list-cache.php illustrates a bigger problem throughout the codebase, where $sid and $msid are used to inject a php session id when needed into links. This convention predates my involvement in Maia, but I think the m stands for multiple, meaning it is used whenever there are more parameters to pass on, which is the error in list-cache.php.

Of interest, though, is the fact that $msid is also correct in single use situations - a trailing '&' doesn't affect anything. So should we just change authcheck.php to make $msid and $sid be equal, being '?PHPSESSID=' . session_id() . '&'

Change History (2)

comment:1 Changed 11 years ago by mortonda@…

  • Component changed from General to PHP scripts
  • Description modified (diff)
  • Milestone set to 1.0.3
  • Owner changed from rjl to mortonda@…
  • Status changed from new to accepted

comment:2 Changed 11 years ago by mortonda@…

  • Resolution set to fixed
  • Status changed from accepted to testing

[1305] and [1306] have this one part fixed. Still open is the question of whether $sid is even needed.

Note: See TracTickets for help on using tickets.