Opened 11 years ago

Last modified 10 years ago

#499 new defect

error checks in perl scripts

Reported by: dmorton Owned by: rjl
Priority: normal Milestone: post-1.0.3 triage
Component: Perl scripts Version: 1.0.2 Devel
Severity: normal Keywords:
Cc:

Description

While helping someone in irc, it was discovered that a typo in a config was causing a file not found error, resulting in a infinite loop in process-quarantine. We need to check for such errors and quit appropriately.

Change History (5)

comment:1 Changed 11 years ago by dmorton

namely $script_dir and $template_dir

comment:2 Changed 11 years ago by dmorton

I can check for these, but there are still problems when the subroutine script cannot run, such as missing libraries - the program gets stuck in an infinite loop.

comment:3 Changed 11 years ago by dmorton

I'd like to look into changing this from a system() call to a fork based program, like http://perldoc.perl.org/perlipc.html#Safe-Pipe-Opens

We could preload all the spamassassin objects which would catch a lot of potential errors before getting into a loop... and the forking would still clean up memory from the scanning process. Preloading the spamassassin objects would also serve to speed up the process a little.

comment:4 Changed 11 years ago by dmorton

see [1262]

comment:5 Changed 10 years ago by mortonda@…

  • Milestone changed from 1.0.3 to post-1.0.3 triage

good enough for 1.0.3, punting to next release

Note: See TracTickets for help on using tickets.