Opened 14 years ago

Last modified 9 years ago

#44 new enhancement

Add search feature for quarantines and ham cache

Reported by: rjl Owned by: rjl
Priority: normal Milestone: post-1.0.3 triage
Component: PHP scripts Version: 1.0.0 RC5
Severity: normal Keywords: spam quarantine ham cache search
Cc:

Description

When the list of items in a quarantine or ham cache is very large, it can be useful to be able to search for something specific rather than paging through the list. A search option would allow users to return a list of items that match the search criteria--a handy way to make sure that a particular e-mail you've been expecting isn't in the spam quarantine, for instance.

Attachments (2)

cache.php.2.diff (1.3 KB) - added by dmorton 11 years ago.
list-cache.tpl.2.diff (12.2 KB) - added by dmorton 11 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by dmorton

  • Milestone 1.0.0 deleted

comment:2 Changed 12 years ago by rjl

  • patch set to 1

Patches by Erik Weber have been added to this ticket as a starting point.

His comments:

There's some stuff that should be fixed in the attached patch files,
didn't really figure out how to make pager_wrapper_db() to accept more
prepares for the $dbparams. Also some better variable names wouldn't
hurt  :-)

There's two language records that I didn't create a patch file for that
has to be added manually

locale/en/quarantine.php:
$lang['text_search'] = "Search for message";
$lang['button_search'] = "Search";

Included patch files: cache.php.diff
themes/theme/templates/list-cache.tpl.diff

Feel free to include it if you want.

Changed 11 years ago by dmorton

Changed 11 years ago by dmorton

comment:3 Changed 11 years ago by dmorton

  • Milestone set to 1.0.3

comment:4 Changed 10 years ago by mortonda@…

This patch supplied appears to take a post, and change it to a GET request - I suppose that makes it easier for paging.

Need to be more careful with the user input, to avoid injection attacks...

Also could add a select box to determine which field to search on: recipient, sender, or subject.

comment:5 Changed 9 years ago by mortonda@…

  • Milestone changed from 1.0.3 to post-1.0.3 triage

I'm not comfortable with the performance aspects of this being so close to a release.

Note: See TracTickets for help on using tickets.