Opened 13 years ago

Closed 10 years ago

#409 closed enhancement (fixed)

patch: improved pagecount + filter on sender_email + confirm highspamscore

Reported by: maarten.vanraes@… Owned by: rjl
Priority: low Milestone: 1.0.3
Component: General Version: 1.0.2
Severity: normal Keywords:
Cc:

Description

patch (only ocean and desert templates)

  • pages are grouped in case of lots of pages
  • extra feature1: filter on sender_email in spam
  • confirm all spam above X score

Change History (5)

comment:1 Changed 13 years ago by anonymous

A few suggestions...

  • There is some text in the templates that needs to be moved to the

appropriate locale file.

  • Should this be visible to all users, or just administrators? Most

users probably don't have a lot of email addresses to filter on.

  • using LIKE '%....%' can have performance problems, since it has to scan

the table and not use indices. I'm not sure of a solution to this, but something to consider.

comment:2 Changed 13 years ago by anonymous

Well, you can do what you want with it,

we're using this at work like this and have a patch we are using for every new version...

I don't have any time for this, so, i'm just giving it to you. i'm definately going to keep patching like this, unless it's already in the release...

nothing personal, i just can't put any time in this

these things are more workarounds-that-work than something else... they are not clean at all...

if anything changes i'll resubmit something...

comment:3 Changed 13 years ago by anonymous

understood... I also had to put that there to remind myself or anyone else

who may wish to integrate it... ;)

comment:4 Changed 11 years ago by mortonda@…

  • Priority changed from normal to low

looks like we lost the patch.

comment:5 Changed 10 years ago by mortonda@…

  • Resolution set to fixed
  • Status changed from new to closed

since we lost the patch, this can't really go much further. I did limit the size of the pager, since it was a simple patch, so I'll claim a partial victory. [1449]

Note: See TracTickets for help on using tickets.