Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#373 closed defect (fixed)

Prune obsolete PHP scripts

Reported by: rjl Owned by: dmorton
Priority: highest Milestone: 1.0.2
Component: PHP scripts Version: 1.0.1
Severity: blocker Keywords: prune obsolete


With the recent switch to list-cache.php, the older PHP scripts like spam-quarantine.php, virus-quarantine.php, attachment-quarantine.php, header-quarantine.php, and ham-cache.php are becoming obsolete. These older scripts are still referenced in some other scripts like stats.php, help.php, viewer.php, and viewmail.php, so those references need to be updated before removing the obsolete scripts. Similarly, there's some confusion over which of view.php, viewer.php, and viewmail.php is actually in use now; any obsolete scripts should be removed, and references to them in other scripts corrected.

Change History (8)

comment:1 Changed 11 years ago by dmorton

I was originally trying to retain the original files for backwards compatability with anyone who had themed their own sites; So while we need to make sure nothing points to the new files, I wanted to leave the files themselves until 1.0.3 or 1.1

comment:2 Changed 11 years ago by rjl

There seems to be some agreement with this. A comment received from Remko Lodder:

Within FreeBSD We dont do such changes till a new release
(1.x -> 2.x) or in this case you could consider doing it
in 1.1. This to maintain compatibility and give users the
time to migrate (if they want).

The problem this poses, though, is that there's no clear mechanism for selecting the new vs. old scripts in the meantime. When we release 1.0.2 with both sets of scripts, we have to choose to either use the new list-cache.php stuff or the older *-quarantine.php stuff by default. If we retain both sets of scripts, we should at least provide some docs in the upgrade instructions about how to switch back to the old-style scripts for those who need to do so, and make sure the new scripts are used by default. Alternatively, this could become a GUI configuration item for the superadmin to toggle on the System Configuration page.

comment:3 Changed 11 years ago by dmorton

the default themes provided should use the new scripts. If someone has a theme of their own, then it will still work with the old scripts; In any case they would need to investigate a lot of changesets between version to update their own theme. This was the largest single change, so I wanted to leave the old scripts behind to giv people time to adapt.

However, we certainly need to make sure the stock themes link only to the new scripts.

The sql query improvements make this a very desirable change; I don't think we want it to wait until 1.1 :)

comment:4 Changed 11 years ago by dmorton

digests is one obvious entry point for this problem it seems... but the code in viewer.php is similar to viewmail.php but with the token stuff... I guess the token stuff needs to be integrated with view.php

comment:5 Changed 11 years ago by dmorton

  • Owner changed from rjl to dmorton
  • Priority changed from normal to high
  • Severity changed from normal to major
  • Status changed from new to assigned

comment:6 Changed 11 years ago by dmorton

  • Priority changed from high to highest
  • Severity changed from major to blocker

comment:7 Changed 11 years ago by anonymous

After looking at the token code that the digests use, I'm not so sure I

want to keep the old scripts around any more. It looks like it would be much simpler and clearer to simply remove the old paths and get everything running with the new paths.

Those who have their own themes always have to retest on a new version anyway... though after 1.0.2 I think we will work on the 1.1 series and not make such changes in 1.0.x

comment:8 Changed 11 years ago by dmorton

  • Resolution set to fixed
  • Status changed from assigned to closed

completed in [1123] [1124]

Note: See TracTickets for help on using tickets.