Opened 14 years ago

Closed 13 years ago

#342 closed defect (fixed)

[patch] locale with html escape chars

Reported by: alex@… Owned by: rjl
Priority: normal Milestone: 1.0.2
Component: PHP scripts Version: 1.0.1
Severity: major Keywords:
Cc:

Description

I've noticed a very nasty bug that append while using button locale text with html escape code like :

>text<

This is true with patched french locale (with full ASCII html patch), when clicking buttons in configuration page, nothing append.

Diving into code, this is caused by the tests mechanism to retrive witch button is pressed :

if ($button == $lang['button_update_address']

but, if $lang[] contain html escpaed chars, test will return false.

So, to solve this issue, there is 2 options :

  • use internal variable that doenst use text button
  • use htmlentities() to convert $button var

First option is probably the better, but require a lot of work. My proposed patch against 1.0.1 is based on the 2nd option, with the use of htmlentities().

Attachments (1)

button-htmlentities.diff (5.5 KB) - added by alex@… 14 years ago.
patch

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by alex@…

patch

comment:1 Changed 14 years ago by rjl

  • Milestone set to 1.0.2
  • Version set to 1.0.1

comment:2 Changed 13 years ago by dmorton

  • Resolution set to fixed
  • Status changed from new to closed

no, your option number one is the right answer, and can be accomplished simply by comparing the name of the variable, and not the value.

Beside the forms listed in this patch, there are some places where there is a input with a name="submit" but there are no more duplicates, so it isn't as critical.

fixed in [1120]

Note: See TracTickets for help on using tickets.