Opened 15 years ago

Closed 14 years ago

Last modified 14 years ago

#290 closed defect (fixed)

$unix_socketname not defined

Reported by: dmorton Owned by: rjl
Priority: normal Milestone: 1.0.2
Component: amavisd-maia Version: 1.0.1
Severity: normal Keywords:
Cc:

Description

I get this with the latest amavisd-maia (987):

Use of uninitialized value in string eq at /usr/local/sbin/amavisd-maia line 10900.

If I add that to my amavisd with an empty value, it works. Looks like it needs to check for if the variable is defined rather than .... or both.

Change History (13)

comment:1 Changed 15 years ago by dmorton

  • Priority changed from normal to highest

comment:2 Changed 15 years ago by dmorton

It broke in [984].

comment:3 Changed 15 years ago by dmorton

  • Severity changed from blocker to major

It doesn't actually stop the server from running... it just looks like an error escapes. I don't see how [984] could cause this... but it does.

comment:4 Changed 15 years ago by dmorton

  • Resolution set to fixed
  • Status changed from new to closed

fixed [988]

comment:5 Changed 15 years ago by dmorton

  • Resolution fixed deleted
  • Severity changed from major to blocker
  • Status changed from closed to reopened

ack, now I get: Net::Server: 2006/04/03-09:47:10 Undeterminate port "" under Net::Server::Proto::TCP\n at line 48 in file /usr/lib/perl5/site_perl/5.8.5/Net/Server/Proto/TCP.pm

comment:6 Changed 15 years ago by dmorton

bad logic... check for "!defined or" instead of "defined and" fixed in [989]

comment:7 Changed 15 years ago by dmorton

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 15 years ago by dmorton

  • Milestone 1.0.1 deleted
  • Resolution fixed deleted
  • Severity changed from blocker to normal
  • Status changed from closed to reopened

After discussion with Robert, The bigger problem seems to be when $forward_method is undefined in the config file, so it is actually somewhat usefull to have some sort of error reported.

comment:9 Changed 15 years ago by dmorton

  • Priority changed from highest to normal

reverted in [999].

Leaving this ticket open and open ended for a milestone. I'm not sure if it's worth working on now.

comment:10 Changed 15 years ago by dmorton

I added the $forward_method to my config file, and left $unix_socketname undefined, and I still get the error.

comment:11 Changed 15 years ago by rjl

  • Milestone set to 1.0.2
  • patch set to 0
  • Version set to 1.0.1

comment:12 Changed 14 years ago by rjl

This issue was reported again today by Manuel Cabrera Caballero. I'm becoming inclined at this point to just remove all references to $unix_socketname from amavisd-maia, since they serve no useful purpose in a Maia installation anyway (they're only used for milter setups, and Maia requires a dual-MTA arrangement, so milters can't be used). I don't see why we can't just add $unix_socketname to the legacyconfvars collection and remove all other references to it, so that it will be safely ignored if it's set in the amavisd.conf file.

comment:13 Changed 14 years ago by dmorton

  • Resolution set to fixed
  • Status changed from reopened to closed

[1126] I think I removed all references to $unix_socketname.

Note: See TracTickets for help on using tickets.