$unix_socketname not defined

[dmorton]

I get this with the latest amavisd-maia (987):

Use of uninitialized value in string eq at /usr/local/sbin/amavisd-maia line 10900.

If I add that to my amavisd with an empty value, it works. Looks like it needs to check for if the variable is defined rather than .... or both.

[dmorton]

It broke in [984].

[dmorton]

It doesn't actually stop the server from running... it just looks like an error escapes. I don't see how [984] could cause this... but it does.

[dmorton]

fixed [988]

[dmorton]

ack, now I get: Net::Server: 2006/04/03-09:47:10 Undeterminate port "" under Net::Server::Proto::TCP\n at line 48 in file /usr/lib/perl5/site_perl/5.8.5/Net/Server/Proto/TCP.pm

[dmorton]

bad logic... check for "!defined or" instead of "defined and" fixed in [989]

[dmorton]

After discussion with Robert, The bigger problem seems to be when $forward_method is undefined in the config file, so it is actually somewhat usefull to have some sort of error reported.

[dmorton]

reverted in [999].

Leaving this ticket open and open ended for a milestone. I'm not sure if it's worth working on now.

[dmorton]

I added the $forward_method to my config file, and left $unix_socketname undefined, and I still get the error.

[rjl]

This issue was reported again today by Manuel Cabrera Caballero. I'm becoming inclined at this point to just remove all references to $unix_socketname from amavisd-maia, since they serve no useful purpose in a Maia installation anyway (they're only used for milter setups, and Maia requires a dual-MTA arrangement, so milters can't be used). I don't see why we can't just add $unix_socketname to the legacyconfvars collection and remove all other references to it, so that it will be safely ignored if it's set in the amavisd.conf file.

[dmorton]

[1126] I think I removed all references to $unix_socketname.