Opened 15 years ago

Closed 11 years ago

#256 closed enhancement (invalid)

[PATCH] popup-mailview patch from Motoharu Kubo

Reported by: dmorton Owned by: rjl
Priority: normal Milestone: 1.0.3
Component: PHP scripts Version: 1.0.0
Severity: normal Keywords:
Cc:

Description

from the maia-devel list: I finished popup-mail view and tested in English and Japanese. Attached patch includes page navigation improvement.

The patch is based on trunk code as of yesterday.

Some notes to the patch:

(1) Page navigation is improved when total pages are large. I modified

*-quarantine.php, ham-cache.php just after calling "$page->build()", and cache_pager.tpl (ocean_surf only).

(2) I added popup_viewmail and use_suspend_column column (both integer)

to maia_users table. I added two user-configurable settings line in settings.php which read:

Mail Viewer should be popup? Yes No Enable "Suspend" column? Yes No

Thus popup-mailview and suspend column (I changed the term "later" to "suspend") are optional for those who want to use these.

(3) The popup-mailview has following features:

# The List window and Mailview window interacts with each other.

  • There is no distinct change to list page, but mailview window pops up when user clicks Subject. In addition selected line is hilighted by different background color.
  • The mailview window has slightly different header and action bar. However main part is exactly the same as non-popup version.
  • Action of mailview is changed. When user clicks "Report this SPAM" or any other button, radio button settings of list window is changed (in other words no immediate action occurs). Next mail is automatically displayed in mailview and corresponding list line is hilighted.
  • "Prev" and "Next" icon is added to action bar of mailview. It simply go to next/previous mail.
  • After checking all mail of current page, user can press "Confirm the Status of these items" button and specified action is executed for all mails displayed in the list window.

I am not sure thease action is what you called "ajax" like, but I love this.

(4) mbstring function is not necessary when user selects ISO-8859-1.

(5) I added some $lang array elements which are necessary for

translation. No elements added are bound to program logic, so no additional translation is not necessary for other languages.

Attachments (1)

maia-popup.diff.gz (17.3 KB) - added by dmorton 15 years ago.
patch file from mailing list

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by dmorton

patch file from mailing list

comment:1 Changed 15 years ago by rjl

  • patch set to 1

comment:2 Changed 15 years ago by rjl

  • Milestone set to 1.0.2

comment:3 Changed 15 years ago by dmorton

cross reference #105 I think the thinkbox idea may be best, as we could also isolate bad html in an iframe or something.

comment:4 Changed 14 years ago by dmorton

  • Milestone changed from 1.0.2 to 1.1.0

comment:5 Changed 11 years ago by mortonda@…

  • Milestone changed from 1.1.0 to 1.0.3
  • Resolution set to invalid
  • Status changed from new to closed

This is obsoleted by the use of a javascript thickbox, and UTF8

Note: See TracTickets for help on using tickets.