Ticket #195 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Don't reminder notices from being sent to users who have disabled certain types of content

Reported by: rjl Owned by: rjl
Priority: normal Milestone: 1.0.1
Component: Perl scripts Version: 1.0.0 RC5
Severity: normal Keywords: send-quarantine-reminders.pl reminders
Cc:

Description

As reported by Greg Woods, reminder notices are still being issued to users who have disabled spam filtering, since items must still be spam-checked as long as at least one recipient has spam-checking enabled. These items show up as "suspected spam" even for the users with spam-filtering disabled, and while the quarantine pages conceal this, the reminder script still sees these items and issues reminder notices. In short, the send-quarantine-reminders.pl script needs to be amended to ignore such items as well.

Change History

Changed 7 years ago by dmorton

Shouldn't the proper fix be to not quarantine them for the given user?

Changed 6 years ago by dmorton

  • milestone changed from 1.0.0 RC6 to 1.1.0

Changed 6 years ago by rjl

  • status changed from new to assigned
  • milestone changed from 1.1.0 to 1.0.1

Changed 6 years ago by rjl

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in [997] and [998]. It's true, though, that it would be better to set a different reference type for such users in the first place, but that's a more complicated issue with a more complicated solution.

As it happens, it doesn't matter much--the items of the unwanted type that get quarantined get safely expired in due course. This fix just prevents those items from triggering a reminder e-mail, hiding them from the user.

Note: See TracTickets for help on using tickets.