Opened 16 years ago

Closed 14 years ago

Last modified 15 years ago

#191 closed defect (fixed)

Fix initial default for mail items, so that they're not assumed to be ham

Reported by: rjl Owned by: dmorton
Priority: low Milestone: 1.0.2
Component: amavisd-maia Version: 1.0.0 RC5
Severity: minor Keywords: default mail type H ham
Cc:

Description

When a mail item is first received by amavisd, it gets assigned a default type of "H" (ham), before being handed off to be classified further. Its type is changed only if it is later determined to be something other than ham.

While this system works well most of the time, it does present one subtle problem from time to time: a user checking his ham cache via the Maia interface at just the wrong moment may see an item listed as ham, just because at that moment the item has not yet made it to amavisd's classification routines. Seeing something that is "obviously" spam in his ham cache, he's likely to report it as a false negative, when in fact if he had simply refreshed his ham cache a second later, that item would have vanished (and correctly shown up on the spam quarantine list).

The easiest solution is to assign a neutral default type (e.g. "X"), so that such items will not be mistaken for ham prematurely. At the end of amavisd's classification system, any items that are still of type "X" should then be promoted to type "H".

Change History (6)

comment:1 Changed 15 years ago by dmorton

Or... When items are submitted, check its type first and do the stats appropriately. Though this route would add more database calls.

comment:2 Changed 15 years ago by dmorton

  • Milestone changed from 1.0.0 to 1.1.0

comment:3 Changed 15 years ago by rjl

  • Milestone changed from 1.1.0 to 1.0.2
  • patch set to 0

comment:4 Changed 15 years ago by rjl

  • Status changed from new to assigned

comment:5 Changed 14 years ago by dmorton

  • Owner changed from rjl to dmorton
  • Status changed from assigned to new

looks like this is easier than I thought. I think all we have to do is

change the default. It appears is always updated in all code paths. The only corner cases I can think of are @. messages ... but I think they are covered to.

line 9637 of revision 1126 has the final conversion.

I made the change locally and I'm watching the database to see if any slip past.

comment:6 Changed 14 years ago by dmorton

  • Resolution set to fixed
  • Status changed from new to closed

slipped into [1132] which was for another ticket, but it was a one liner.

Works great on my system.

Note: See TracTickets for help on using tickets.