Ticket #173 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

[PATCH] Language incorrectly loaded, translation for dutch, dutch welcome.php missing

Reported by: maia at hoekstra dot nu Owned by: dmorton
Priority: normal Milestone: 1.0.0 RC6
Component: PHP scripts Version: 1.0.0 RC6
Severity: minor Keywords: language, locale
Cc:

Description

When going to settings, selecting a new language, all goes fine.

When closing the browser, starting it up again, going to the maia login, it will show in default language (english for me), and after logging in, instead of switching back to the locale language (Dutch for me), it remains 'default (en)' until I reconfirm in the settings page that I want Dutch menus.

Also, I have translated all dutch locale files.

Lastly, the welcome.php is missing in the dutch locale. While I have translated the files, I could send them to who wants it for integration with the trunk version?

Attachments

nl.diff (82.2 kB) - added by maia at hoekstra dot nu 10 years ago.
Diff: Translation for dutch locale

Change History

Changed 10 years ago by dmorton

When you restart your browser and go to the login screen, is there a lang=xx in the URL? If there is, it probably overrides your user setting.

I guess that's an interesting question: if you click on another language, and then log in, shouldn't be the same language, regardless of what your setting is?

I need to look into how to set the default language, though.

Post a patch of the locale files here as an attachment, and we'll get them integrated.

Changed 10 years ago by maia at hoekstra dot nu

The lang= is not in my URL . . .

Flow: (default setting = english)

Startup browser Goto login screen (English) Logged in (English) Settings page (English) Apply settings (Dutch) Logout (Dutch) Re-enter login screen (Dutch) shut down browser. < loop around >

I have almost finished all translations, I'll post the patch soon.

Changed 10 years ago by maia at hoekstra dot nu

Diff: Translation for dutch locale

Changed 10 years ago by dmorton

  • owner changed from rjl to dmorton
  • status changed from new to assigned
  • milestone set to 1.0.0 RC6

Locale update applied in [598]

Changed 9 years ago by dmorton

Ok, there's a hidden input tag that is setting the language to the default language. We need to differentiate between that, and the possible url parameter, and a user's settings and figure out which one gets the priority.

I think the priority should be:

  1. If a specific language is picked on the login page, make that the language used
    • Possibly ask user if they want to change their default language?
  2. user's preference in settings
  3. default language. (but how is this reachable, given the existance of option 2?)

Changed 9 years ago by dmorton

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in [656].

Opening new ticket for wizard page idea.

Changed 9 years ago by rjl

  • summary changed from Language incorrectly loaded, translation for dutch, dutch welcome.php missing to [PATCH] Language incorrectly loaded, translation for dutch, dutch welcome.php missing
Note: See TracTickets for help on using tickets.